[MERGE] [BUG 363837] Catch _win32_delete_readonly failure to remove file or directory and try to recover

[Alexander Belchenko]

Martin Pool пишет:
> 2009/5/6 John Arbash Meinel <john at arbash-meinel.com>:
>> I think we could
>>
>> 1) Insert a small wait loop after the process goes away to see if it
>> releases the file. This will help fix transient things. We could try
>> every 100ms or so, for a max of 1s.

For diff there will be 2 files, for merge up to 3 files. So in the bad 
possible situation bzr will wait up to 3 minutes just to try cleanup 
things? Do you think it's really better than exit immediately and print 
the names of files those are left?

>> 2) After waiting, just give up with a warning that we couldn't delete
>> the file.
> 
> This would be fine.  I don't know if it's a very high priority as
> leaking a few temporary files, from an operation that's probably only
> manually initiated should not be a big deal, but a patch for it would
> be fine.
> 
>> I would make this very specific to windows + diff handling, rather than
>> do it for all files we want to delete. I suppose 1&2 aren't terrible for
>> generic, but I think we'll often have things open that won't be
>> released, like Visual Studio editing.
> 
> I don't think it should be done from every delete operation, but I do
> think it should be put in eg osutils where we can call it in other
> cases.  For example I bet people sometimes get merge failures when it
> wants to delete a file that's presently in use.  (Or maybe
> treetransform already specially handles this?)  And I think there was
> a one-off failure which seemed due to a virus scanner reading a file
> in .bzr when we wanted to delete it.
>