[MERGE] Report the number of VFS calls in -Dhpss output

[Jonathan Lange]

On Wed, May 6, 2009 at 8:03 AM, Martin Pool <mbp at canonical.com> wrote:
> Martin Pool has voted tweak.
> Status is now: Conditionally approved
> Comment:
> It's ok with me too though you might wait a couple of days for Andrew.
>
>         medium_repr = repr(medium)
>         # Add this medium to the WeakKeyDictionary
> -        self.counts[medium] = [0, medium_repr]
> +        self.counts[medium] = [0, 0, medium_repr]
>
> At any more than 3 elements this would want to be a dict or something rather
> than a list indexed by integers.  I think you (or the merge submitter)
> should at least add a comment here saying what they are.
>

I changed it to use a dict.

> In passing, now that this holds a medium_repr rather than the actual medium,
> is there any need for it to be a weakref?

Not a clue. Ask Andrew.

jml
-------------- next part --------------
A non-text attachment was scrubbed...
Name: report-vfs-calls.patch
Type: text/x-diff
Size: 5307 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090506/1dfe8224/attachment-0001.bin