[MERGE] Report the number of VFS calls in -Dhpss output
John Arbash Meinel
john at arbash-meinel.com
Tue May 5 15:37:48 BST 2009
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Jonathan Lange wrote:
> Hello,
>
> As discussed in an earlier thread, this patch extends the smart
> server's _DebugCounter to maintain a separate count of VFS calls.
>
> It does this by inspecting the 'method' attribute of params, fetching
> the request object from the registry and checking to see whether it's
> a subclass of VfsRequest.
>
> I've updated the NEWS file, but didn't write any tests, since I
> couldn't find any for the existing functionality. I did double check
> the count against the .bzr.log though, and the numbers work out just
> fine.
>
> jml
>
BB:comment
The change looks fine to me. I would approve, but I think someone like
Andrew should give it a look over first.
If you don't get a response after a couple days, remind me to bump this
to approve and submit.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkoATzwACgkQJdeBCYSNAAN4IwCfctadMURCI8sB+/q1lJm1Pssn
7IkAoLx/GOVrOkYsUGhmGaAlNf5yPI8d
=oaIH
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list