[MERGE] Lock repositories created by BzrDirFormat.initialize_on_transport_ex.

Robert Collins robert.collins at canonical.com
Thu Apr 30 23:47:34 BST 2009

On Thu, 2009-04-30 at 13:15 -0400, John Arbash Meinel wrote:
> John Arbash Meinel has voted approve.
> Status is now: Approved
> Comment:
> I really like the idea of having 'initialize' of an object return a 
> write-locked object. However, this feels like changing an api 
> after-the-fact. (It used to return unlocked repos, and now it returns 
> locked repos.)
> However, as I don't see 'initialize_on_transport_ex' in bzr.1.14 it 
> seems like a good time to get this change in. Can you confirm that the 
> api hasn't been released yet?

The API hasn't been in a release. The changes made to the RPC are
actually compatible though, for all our current formats, because the
client would keep working and a 'lock' on a pack repo is entirely

> Same thing for the RPC, I'd like to not change it after it has been 
> released, but it looks like this only exists in bzr.dev.
> @@ -3149,7 +3154,7 @@
>           format = RemoteBzrDirFormat()
>           format._network_name = bzrdir_name
>           self._supply_sub_formats_to(format)
> -        bzrdir = remote.RemoteBzrDir(transport, format)
> +        bzrdir = remote.RemoteBzrDir(transport, format, _client=client)
>           if repo_path:
>               repo_format = 
> remote.response_tuple_to_repo_format(response[1:])
>               if repo_path == '.':
> ^- Can you explain this a bit?

This is the previous commit in the branch, also in this bundle, what it
does is avoids probing for the bzrdir which we know exists.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090501/de73f55f/attachment.pgp 

More information about the bazaar mailing list