[MERGE] Lock repositories created by BzrDirFormat.initialize_on_transport_ex.

[John Arbash Meinel]

John Arbash Meinel has voted approve.
Status is now: Approved
Comment:
I really like the idea of having 'initialize' of an object return a 
write-locked object. However, this feels like changing an api 
after-the-fact. (It used to return unlocked repos, and now it returns 
locked repos.)

However, as I don't see 'initialize_on_transport_ex' in bzr.1.14 it 
seems like a good time to get this change in. Can you confirm that the 
api hasn't been released yet?

Same thing for the RPC, I'd like to not change it after it has been 
released, but it looks like this only exists in bzr.dev.

@@ -3149,7 +3154,7 @@
          format = RemoteBzrDirFormat()
          format._network_name = bzrdir_name
          self._supply_sub_formats_to(format)
-        bzrdir = remote.RemoteBzrDir(transport, format)
+        bzrdir = remote.RemoteBzrDir(transport, format, _client=client)
          if repo_path:
              repo_format = 
remote.response_tuple_to_repo_format(response[1:])
              if repo_path == '.':

^- Can you explain this a bit?


For details, see: 
http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C1240891109.5830.1.camel%40lifeless-64%3E
Project: Bazaar