[rfc] time to switch to Launchpad reviews

Michael Hudson michael.hudson at canonical.com
Sun Apr 26 07:46:17 BST 2009

Jelmer Vernooij wrote:
> Hi Martin,
> Am Fri, 24 Apr 2009 09:46:18 +0100 schrieb Martin Pool:
>> I think it's about time to switch from doing code reviews in Bundle
>> Buggy to doing it through Launchpad's new code review feature.  It can
>> integrate with mail, it makes it a bit easier for other people to
>> comment or to attach them to/from bugs, it's the way of the future(tm),
>> and we're already getting people spontaneously posting up branches so
>> things are split across two places.  BB has been a great bit of work,
>> but maybe now served its time.
>>   https://launchpad.net/+tour/code-review
>>   http://blog.launchpad.net/cool-new-stuff/email-interface-to-code-
> review
>> I've used it a bit myself, as have some others for other projects.
>> Improvements are possible but I think it's pretty good now.
>> Any comments, particularly from people who're participating in
>> development or review at the moment?
>> If there are no blockers I propose that we change the standard practice
>> to posting merge proposals rather than to BB, leave BB running as a
>> backup, and then if that goes well change the normal practice across.
> Maybe not really a blocker, but the BB UI is a lot easier to use than the 
> Launchpad one. 
> I especially like the various tabs with relevant merge requests to me 
> that BB offers. As far as I can tell at least there's nothing like this 
> in Launchpad. 

There's http://code.launchpad.net/bzr/+activereviews, and soon there
will be http://code.launchpad.net/~jelmer/+activereviews.

> The colors with the merge request statusses is also a lot
> clearer.
> Perhaps more importantly, there's the issue of starting to depend on more 
> non-Free Software for Bazaar. I could improve BundleBuggy (and have in 
> fact, although the actual amount of contributions I've made is limited), 
> I can't do anything about Launchpad.

Launchpad will be free software in July (and while bits of codehosting
might not be being released, the code review stuff is).


More information about the bazaar mailing list