[bug 248932] reconfigure --standalone creates incompatibe repository

[Martin von Gagern]

Hi!

Find attached a draft towards fixing bug #248932
https://bugs.launchpad.net/bzr/+bug/248932

Problem: reconfigure --standalone creates repositories of default type,
which may differ in rich root support, among others.
Solution: Instead the new repository should use the same format as the
original shared repository, imho.

The patch introduces a blackbox unit test to expose the problem, as well
as a quick and dirty hack to solve it. This is not considered a merge
proposal, but rather a draft to start discussing.

Problems with my approach, and possible solutions:
1. Disregards encapsulation by directly accessing
   - BzrDir._format and
   - Repository._format
   a) introduce getter/setter methods
   b) introduce properties
   c) Pass Repository to BzrDir to have it copy the format
2. Modifies a BzrDirFormat object which might be shared
   a) clone object
   b) ensure the object is never reused elsewhere
3. Bad exception handling for
   - read-only BzrDirFormat.repository_format and
   - unset BzrDir._format
   a) identify expected problem situations and deal with them

Please comment on these problems and tell me what you think.

I would have pushed a branch if I hadn't been biten by bug 356699
(preventing upload on a slow connection) and bug 343960 (which prevented
execution of bzr in the first place on a remote fast connection).
Instead you have to make do with the attached merge directive.

Greetings,
 Martin
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bug248932a.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20090417/cf4dea3a/attachment-0001.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090417/cf4dea3a/attachment-0001.pgp