[MERGE] Prompt for user names if they are not in the configuration.

Vincent Ladeuil v.ladeuil+lp at free.fr
Tue Apr 7 11:30:31 BST 2009


>>>>> "Jelmer" == Jelmer Vernooij <jelmer at vernstok.nl> writes:

    Jelmer> Jelmer Vernooij wrote:
    >> The attached patch makes bzr prompt for user names when it needs to 
    >> authenticate but there is no username known, similar to what's already done 
    >> for passwords.
    >> 

    Jelmer> Updated patch with changes requested by Vincent: get_user() now defaults
    Jelmer> to returning getpass.getuser(), to match current behaviour unless
    Jelmer> explicitly requested (as is done for http) in which case it will prompt
    Jelmer> the user.

This sounds good except for the missing tests that http will
indeed prompt for a user and that the other transports won't
(sftp and ftp will be enough for the "other" and even sftp...).

A patch against bzr.dev once your submission for get_username is
merged will be clearer.

BB:resubmit

      Vincent



More information about the bazaar mailing list