[MERGE] Prompt for user names if they are not in the configuration.

[Jelmer Vernooij]

Hi Vincent,

Vincent Ladeuil wrote:
>>>>>> "Jelmer" == Jelmer Vernooij <jelmer at vernstok.nl> writes:
>>>>>>             
>
>     Jelmer> Jelmer Vernooij wrote:
>     >> The attached patch makes bzr prompt for user names when it needs to 
>     >> authenticate but there is no username known, similar to what's already done 
>     >> for passwords.
>     >> 
>
>     Jelmer> Updated patch with changes requested by Vincent: get_user() now defaults
>     Jelmer> to returning getpass.getuser(), to match current behaviour unless
>     Jelmer> explicitly requested (as is done for http) in which case it will prompt
>     Jelmer> the user.
>
> This sounds good except for the missing tests that http will
> indeed prompt for a user and that the other transports won't
> (sftp and ftp will be enough for the "other" and even sftp...).
>
> A patch against bzr.dev once your submission for get_username is
> merged will be clearer.
>   
The attached patch adds these tests. Please let me know what you think.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: username.diff
Type: text/x-patch
Size: 28919 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090409/08f61325/attachment-0001.bin