[MERGE] CHK maps (brisbane)

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Thu, 2009-04-02 at 21:55 -0500, John Arbash Meinel wrote:
> 
>> Since I only need crc32, I would recommend just pulling that bit of code
>> into this file.
>>
>> There are tons of IFDEF in the crc32.c code, that I think we can pretty
>> much just get rid of.
>>
>> If it is going to delay anything, I suppose we can postpone. But it does
>> mean we start depending on having a separate 'z' library to compile against.
> 
> Well, only the C version needs this, and you need libz to link against
> python anyway if python linked against it, so its not an additional
> dependency.
> 

As mentioned in the part you cut out, at least on Windows python
compiles its *own* static zlib, and doesn't export any of the symbols.
So you actually either end up linking yet-another static zlib or the
zlib dll.


>> Another possibility is to just remove the optimized _search_key
>> functions. If we write the other code properly, they don't have to get
>> called all that often.
>>
>> What do other's think?
> 
> I'm happy as-is.
> 
> -Rob

Good enough, I figured I'd mention the concern.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknVf58ACgkQJdeBCYSNAAMkswCbBGmbjpopzjixdyRfb9Bsd9zT
Pv8An32SfSlFfI+TUrc80Qr3Xh19TV+K
=lUHJ
-----END PGP SIGNATURE-----