[MERGE] CHK maps (brisbane)

Robert Collins robert.collins at canonical.com
Fri Apr 3 04:09:35 BST 2009


On Thu, 2009-04-02 at 21:55 -0500, John Arbash Meinel wrote:

> Since I only need crc32, I would recommend just pulling that bit of code
> into this file.
> 
> There are tons of IFDEF in the crc32.c code, that I think we can pretty
> much just get rid of.
> 
> If it is going to delay anything, I suppose we can postpone. But it does
> mean we start depending on having a separate 'z' library to compile against.

Well, only the C version needs this, and you need libz to link against
python anyway if python linked against it, so its not an additional
dependency.

> Another possibility is to just remove the optimized _search_key
> functions. If we write the other code properly, they don't have to get
> called all that often.
> 
> What do other's think?

I'm happy as-is.

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090403/9209d0fa/attachment.pgp 


More information about the bazaar mailing list