[MERGE] Add BranchBzrDirInter.push()

Jelmer Vernooij jelmer at samba.org
Wed Apr 1 13:35:22 BST 2009


On Wed, Apr 01, 2009 at 04:26:25PM +1100, Robert Collins wrote:
> On Tue, 2009-03-31 at 01:56 +0200, Jelmer Vernooij wrote:

> > The BranchBzrDirInter object controls push and branch operations from
> > a
> > source branch to a target bzrdir that may or not may contain a branch
> > yet.

> This may not be needed anymore - bzrlib internals are moving more and
> more to having a single call to do initial push *anyway* simply to make
> the bzr:// performance better. Our code would be simpler without it
> (though if its needed, its needed).

> At this point regarding the patch - the inter object should not be in
> _push.py, and we need unit tests on the behaviour of the object.

> But like a say, It looks to me like its _very_ close to not being needed
> and instead a simple method on BzrDir will do what you need.
What about the attached patch? I wasn't sure how to name the method on
BzrDir, so I've named it "push" for now, suggestions for better names
are welcome.

Cheers,

Jelmer



More information about the bazaar mailing list