bzr 1.14 release schedule and manager

Alexander Belchenko bialix at ukr.net
Thu Mar 26 18:07:22 GMT 2009


John Arbash Meinel пишет:
> Alexander Belchenko wrote:
>> John Arbash Meinel ?8H5B:
>>>> c:\work\Bazaar\mydev.packs\brisbane-core\bzrlib\delta.h(87) : error
>>>> C2054: expected '(' to follow 'inline'
>>> It sounds like we just need to remove the "inline" statement. Can you
>>> try removing that and see if it still compiles? I don't think this
>>> particular code is performance critical enough that we *need* inline.
>> Yes, this helps.
>> IIUC, inline it's C99 extension, but MSVC understand C89 only.
> 
> Well, I think MSVC uses something like __inline, or maybe _inline, or
> some other directive to handle it. I know it *does* support it, just not
> like GCC. :(

According to MSDN:

The inline keyword is available only in C++. The __inline and __forceinline keywords are available
in both C and C++. For compatibility with previous versions, _inline is a synonym for __inline.

IMO it's easy to provide support for both GCC and MSVC with following construct:

#ifdef _MSC_VER  /* MSVC */
#define  INLINE  __inline
#else   /* GCC */
#define  INLINE  inline
#endif

And then use INLINE if needed.




More information about the bazaar mailing list