bzr 1.14 release schedule and manager
John Arbash Meinel
john at arbash-meinel.com
Thu Mar 26 16:30:25 GMT 2009
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Alexander Belchenko wrote:
> John Arbash Meinel пишет:
>>> c:\work\Bazaar\mydev.packs\brisbane-core\bzrlib\delta.h(87) : error
>>> C2054: expected '(' to follow 'inline'
>
>> It sounds like we just need to remove the "inline" statement. Can you
>> try removing that and see if it still compiles? I don't think this
>> particular code is performance critical enough that we *need* inline.
>
> Yes, this helps.
> IIUC, inline it's C99 extension, but MSVC understand C89 only.
Well, I think MSVC uses something like __inline, or maybe _inline, or
some other directive to handle it. I know it *does* support it, just not
like GCC. :(
Anyway, I went ahead and removed the 'inline' declaration, and also
removed 'const' because that was causing compiler warnings. I don't
really understand why:
void my_func(const unsigned char **bar)
{
}
void other()
{
unsigned char *foo = "some stuff";
my_func(&foo);
}
complains about 'const' issues. Since under normal circumstances an
'unsigned char *' can be freely sent to a 'const unsigned char*'. I
guess I'll chalk it up to compilers being stupid, but if someone has
better info, I'm listening.
I also know there is something about the difference between:
const unsigned char *
and
unsigned char const *
Especially versus
unsigned char const * const *
Which I believe is the correct way to say that you have a pointer you
shouldn't modify pointing to data you shouldn't modify.
What we want is a pointer that we can assign to, which references data
that we shouldn't assign to. For which "const unsigned char **" seems to
work, as would "unsigned char const **". But it seems to think that
"&(unsigned char*)" is not valid for... :(
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAknLraEACgkQJdeBCYSNAAPNqQCgoufprijUSS94tJX482KCU7cx
OwcAn3ffUuIY96dSlRBP3IuIRqihRfDA
=0yLI
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list