[MERGE] Remove the basis_tree parameter to record_iter_changes.

[Robert Collins]

On Fri, 2009-03-20 at 17:32 +1100, Robert Collins wrote:

> > ...
> > +            # NB:XXX: We are reconstructing path information we had, this
> > +            # should be preserved instead.
> > 
> > ^- It seems like you could trivially do this by changing the
> > 'parent_entries' dict, to instead be:
> > parent_entries[file_id] = {revision:(ie, path)}
> 
> Thanks, I'll look at that.

Actually, its not parent entries that we relook up in; it is solvable
but doesn't have to be in the first pass.


> (we only get a head candidate for the current tree if it had the file).
> so yes, I agree, and I think it exposes a test hole. I'll look for that
> as this is an area that comprehensive testing is extremely important
> for.

I've added tests for this.

I'm landing this now as I think there is now sufficient coverage, and
this will make testing it in brisbane core easier.

-Rob
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090323/64ddb9a9/attachment.pgp