[MERGE] Remove the basis_tree parameter to record_iter_changes.

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Fri, 2009-03-20 at 09:12 -0500, John Arbash Meinel wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Robert Collins wrote:
>> ...
>>
>>>> ^- another comment here for:
>>>> # change: (old-path, new-path, file_id, new_ie)
>>> Actually, this is a terrible smell. Whats the point of docstrings on
>>> make_delta etc if we are reinventing them with comments everywhere.
>> We chose to go with tuples for performance, but they are awful for
>> maintaining code. It is a real pain to have to go look at the doc string
>> of iter_changes() and _make_delta() every time I'm trying to verify
>> "what is foo[4] again?"
>>
>> I agree there is the the potential for skew, but if we get skew in a
>> tuple-based api, things are rather difficult anyway. I don't really
>> *like* putting the comments in, I just like it more than having to keep
>> extra windows open so I can remind myself what the things I'm looking at
>> really are.
> 
> Compromise then: I'll put such comments in whenever I open a window to
> look one up?

Fair enough, I guess :).

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknG5NkACgkQJdeBCYSNAANkswCgjXmhn4fsPfdGMqvO2NEDt0dn
guEAnjs6jqHhlcCSsXm/NhO/sVDh+Kcy
=0Y5Q
-----END PGP SIGNATURE-----