brisbane:CHKInventory._extract_all_inventory

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> John Arbash Meinel wrote:
>> Ian Clatworthy wrote:
>>> John Arbash Meinel wrote:
>>>> I did some timing tests, and I found the current
>>>> "CHKInventory.iter_entries()" to be a lot slower than it needs to be.
>>> Yes, I've been running into the same thing.
> 
>> So Ian-
>> before you implement _extract_all_inventory fully, either look into
>> fixing iteritems() as I listed, or wait for me to do so. (I probably
>> won't get to it in the next few days, because I'm working on getting
>> groupcompress blocks to stream properly.) If you would rather I do it,
>> just let me know. I think I have a good handle on it, it is just going
>> to take me a while to get around to it.
> 
> Sure. I'm yet to begin working on it. I did test your patch though to
> see the impact on check speed. It increased it from 31 secs to 49 secs
> fwiw.
> 
> Ian C.
> 

Note that my patch doesn't do anything clever about knowing that the
extract_all has already been done. So if you are calling iter_entries()
multiple times for a given inventory, it should be *much* slower.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkm/HI4ACgkQJdeBCYSNAAMkyACfU5KeEuNiAmD+z0pSY6miUnGE
4pwAoLp79ecW4QBpsk4okXPTHv1zclDe
=gsh2
-----END PGP SIGNATURE-----