brisbane:CHKInventory._extract_all_inventory

Ian Clatworthy ian.clatworthy at internode.on.net
Tue Mar 17 03:24:28 GMT 2009


John Arbash Meinel wrote:
> Ian Clatworthy wrote:
>> John Arbash Meinel wrote:
>>> I did some timing tests, and I found the current
>>> "CHKInventory.iter_entries()" to be a lot slower than it needs to be.
>> Yes, I've been running into the same thing.

> So Ian-
> before you implement _extract_all_inventory fully, either look into
> fixing iteritems() as I listed, or wait for me to do so. (I probably
> won't get to it in the next few days, because I'm working on getting
> groupcompress blocks to stream properly.) If you would rather I do it,
> just let me know. I think I have a good handle on it, it is just going
> to take me a while to get around to it.

Sure. I'm yet to begin working on it. I did test your patch though to
see the impact on check speed. It increased it from 31 secs to 49 secs
fwiw.

Ian C.



More information about the bazaar mailing list