[merge][#165014] url parser accepts IPv6 literals

Martin Pool mbp at sourcefrog.net
Tue Mar 17 01:36:54 GMT 2009

2009/3/12 Lukas Zapletal <lukas91 at zapletalovi.com>:
> Martin Pool napsal(a):
>> Martin Pool has voted reject.
>> Status is now: Vetoed
>> Comment:
>> Causes test failures and not a priority for me at the moment, so closing
>> the patch.
>> For details, see:
>> http://bundlebuggy.aaronbentley.com/project/bzr/request/%3Ce01316480811301945p590d4c16qa79efafdd4cde4e8%40mail.gmail.com%3E
>> Project: Bazaar
> Can I vote for the patch as a non-developer?

Technically no, but actually yes.  By that I mean, in BB only
developers can vote, but we're very happy for you to fix up this patch
and ask for it to be merged.

What I suggest you do is: merge that patch into a branch of bzr trunk,
and see if it passes all the tests by running './bzr --no-plugins
selftest'.  If it does, great.  If not, try to fix them by asking for
help here or in #bzr.  I think it will fail but only small changes to
the url parsing functions will be needed to make it pass.  Once it's
all passing, push up your branch to Launchpad and through the
interface there ask for it to be merged into bzr trunk.  Don't
hesitate to ask for help at any stage.

Martin <http://launchpad.net/~mbp/>

More information about the bazaar mailing list