[MERGE][#334114][1.13] Fix bogus 'Source format does not support stacking' warning when pushing to smart server

[Andrew Bennetts]

This patch fixes a rather annoying bug, #334114, which causes incorrect
warnings that the “Source format does not support stacking” when pushing to
a smart server with a default stacking policy.  This particularly affects
pushes to Launchpad.

The root cause is simply that RemoteBranchFormat didn't override
supports_stacking.  This bug has been lurking harmlessly for several
releases, but the HPSS improvements in 1.13 made RemoteBranchFormat used
more often, triggering the visible problem.

This patch adds far more tests that strictly necessary; it took me a while
to figure out the real cause of the bug.  I think the extra tests add
worthwhile coverage.  In case you're curious, the only test I added that
fails without the fix is the one in test_remote.py.

This bug is a regression from 1.13, so I think we should merge this fix to 1.13
as well as bzr.dev.

-Andrew.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-stackable-source-4106.patch
Type: text/x-diff
Size: 12832 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090311/09fd94c4/attachment.bin