[brisbane-core MERGE/RFC] InternalNode.iteritems() broken

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> It's taken several hours but I've finally tracked down why
> path2id() was returning None for some import data streams
> but not others. It seems that the moment the parent_id_basename_to_file_id
> CHKMap overflows from one node to several, the children
> property suddenly becomes [] because iteritems() on the
> root_node was invoking the InternalNode method, not the LeafNode
> one! I suspect this bug was the one causing me lots of
> grief last week w.r.t. bzr ls -r-1 coming up empty on some
> trees but not others.
> 
> Anyhow, I've attached a simple workaround patch until someone smarter
> than me can find the deeper bug.
> 
> Ian C.
> 
> 

I'm fine approving this for now. My guess is the key-filter is doing
something wrong in this situation, and we'll need a good test for it.

My first guess is that it has something to do with the 'search_key'
being different from the 'serialized_key' for hash based chk's. I'll
take a look at it.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmxMe0ACgkQJdeBCYSNAAPuIACgqsNjdr4Wor5JN8Cw+uXkqzmb
5JUAn2ltdFVIHVl+AugJCPr7pmrmRy7l
=imcZ
-----END PGP SIGNATURE-----