[patch][1.13 please] Ressurect progress bar for native Windows shell (bug #334808)
Alexander Belchenko
bialix at ukr.net
Fri Mar 6 10:14:11 GMT 2009
https://bugs.launchpad.net/bugs/334808
New progress bar implemented by Martin Pool (in revno.3882.8.11)
has very clearly visible regression on native Windows shell (not Cygwin):
there is no progress bar at all.
This bug exists because of following (wrong) check in bzrlib/ui/__init__.py
elif os.environ.get('TERM') in (None, 'dumb', ''):
# e.g. emacs compile window
cls = CLIUIFactory
Native Windows shell *never* has TERM environment variable.
BTW, old code that still exists in bzrlib/progress.py uses another check:
if os.environ.get('TERM') == 'dumb':
# e.g. emacs compile window
return False
This patch removes None from bad TERM values, and fixes problem for me.
It's trivial enough. Please merge it into 1.13.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bug-334808.diff
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20090306/cecb9b91/attachment.diff
More information about the bazaar
mailing list