[MERGE] Exception when pulling from a location

Martin Pool mbp at sourcefrog.net
Mon Mar 2 02:18:14 GMT 2009


2009/3/2 Andrew Bennetts <andrew.bennetts at canonical.com>:
> Andrew Bennetts has voted comment.
> Status is now: Semi-approved
> Comment:
> Aaron, John: ping.  The conversation about this branch has stalled.
>
> Some quick 2c from me:
>  * HTTP at least makes it possible to put a bundle at a URL ending in /. I
> don't know if we care or not.

I think that looking at the URL to work out whether it's a bundle or
not is probably a mistake.  There are plausible cases on http where a
regular file has a text content, and there are many cases where
something will be a directory and not have a trailing slash.  We
should just try to read from it, and if the transport says "you can't
read from this, it's a directory" then act.

In other words it doesn't work reliably so it probably just complicates things.

>  * the change of handling to ConnectionError sounds reasonable to me,
> although I haven't looked at it very closely.

That said I don't object to this landing if John thinks it's an
incremental improvement.

-- 
Martin <http://launchpad.net/~mbp/>



More information about the bazaar mailing list