[MERGE] Exception when pulling from a location

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> 2009/3/2 Andrew Bennetts <andrew.bennetts at canonical.com>:
>> Andrew Bennetts has voted comment.
>> Status is now: Semi-approved
>> Comment:
>> Aaron, John: ping.  The conversation about this branch has stalled.
>>
>> Some quick 2c from me:
>>  * HTTP at least makes it possible to put a bundle at a URL ending in /. I
>> don't know if we care or not.
> 
> I think that looking at the URL to work out whether it's a bundle or
> not is probably a mistake.  There are plausible cases on http where a
> regular file has a text content, and there are many cases where
> something will be a directory and not have a trailing slash.  We
> should just try to read from it, and if the transport says "you can't
> read from this, it's a directory" then act.
> 
> In other words it doesn't work reliably so it probably just complicates things.
> 

I'm fine just removing it, if we decide to do so. I think it doesn't
gain us much either way. (With the '/' you can at least bypass the
mechanism, which means that 'bzr merge http://bazaar.launchpad.net/.../'
won't tell you that it is redirected to .../changes before it goes ahead
and does the merge.)

The way it was written, it did nothing. So either we remove it entirely,
or we move it up the stack. If people want it removed, I can do that.

>>  * the change of handling to ConnectionError sounds reasonable to me,
>> although I haven't looked at it very closely.
> 
> That said I don't object to this landing if John thinks it's an
> incremental improvement.
> 

I do think the connection error handling is an improvement. Arguably it
is a bug in the paramiko transport that it will break if you try to
connect twice through the same Transport object, but this is a fairly
simple fix.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmr6VIACgkQJdeBCYSNAAMG4ACfU453OkkbDqG7x/QUgYHECz8U
CiIAn0kU6EZlwFSWVh6nCnocELYWwmKY
=C7cU
-----END PGP SIGNATURE-----