[MERGE] Allow HTTP authentication handlers (such as the NegotiateAuthHandler) to

Vincent Ladeuil v.ladeuil+lp at free.fr
Wed Feb 25 19:31:21 GMT 2009


>>>>> "jam" == John Arbash Meinel <john at arbash-meinel.com> writes:

    jam> John Arbash Meinel has voted tweak.
    jam> Status is now: Conditionally approved
    jam> Comment:
    jam> Do I understand that the *base* implementation now claims
    jam> "requires_username = False" ? (It is a bit hard to tell from the
    jam> diff.)

    jam> I would probably default to True, as it seems more likely.

    jam> Any chance you could add a test for this ?

    jam> (That if requires_username = False' we don't ask for a
    jam> username when authenticating and still authenticate ?)

Unfortunately, the only scheme that permits that (Negotiate)
can't be tested easily as it requires a kerberos infrastructure
:-/

I talked with Jelmer about this patch and the the other related
one (sorry about that, I should have BB:comment on them) and will
send a patch myself.

  Vincent




More information about the bazaar mailing list