[MERGE/RFC] Content filters - take 6
robertc at robertcollins.net
Fri Feb 20 21:53:18 GMT 2009
On Fri, 2009-02-20 at 08:57 -0600, John Arbash Meinel wrote:
> > This method get_file_with_stat seems a bit dangerous because the
> > size in the stat object may be inconsistent with what's actually
> > returned; I'd like to see if we could deprecate this method.
> The reason to have it was to have a "non-racing" implementation to get
> the content and the stat. Otherwise if you read at a separate time
> you stat, something could have changed in the mean-time.
> I believe the stat is only really used to pass back to the dirstate to
> have it mark the file as "unchanged since last commit".
Yah, its an abstraction on file handle basically. If the size changes we
get a stat cache miss -> no problem. And the stat we get is the stat on
the file we read, not on a different file mv'd into place during the
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090221/f7891c38/attachment.pgp
More information about the bazaar