User feedback on filtered views UI needed please

[Alexander Belchenko]

Ian Clatworthy пишет:
> Talden wrote:
>>> See http://bazaar-vcs.org/FilteredViews for information
>>> on how filtered views are proposed to work and how to
>>> test them. I've submitted an updated patch to the mailing
>>> list to make it easier to apply to the current bzr.dev.
>>> Alternatively, you can grab the branch from
>>> lp:~ian-clatworthy/bzr/bzr.views.
>> I got the patch applied to bzr.dev r4000.  The instructions on the
>> webpage to upgrade to wt5 don't work for me though
>>
>> Branching my bzr.dev into a new repo of the default format I tried to
>> upgrade to wt5 as per instructions and get an error
>>
>> Here's some shell output
> 
> ....
> 
>> What'd I miss?
> 
> https://bugs.launchpad.net/bzr/+bug/328135 has been raised by Wesley
> in the last few hours. I can't reproduce it. :-(

I can reproduce it after I build 1.12rc1 bzr.exe on my machine.
You can't reproduce it by running bzr 1.12rc1 manually?
Selftest is not interesting here because it hides circular import errors.

> I wonder if it's a Windows vs Linux thing?

I don't think so. Maybe version of Python.

There is clearly circular import involved, and this is bad:

workingtree.py line 2957 is:

__default_format = WorkingTreeFormat4()

The name WorkingTreeFormat4 is lazy imported from workingtree_4.py

But in the same time at the beginning of workingtree_4.py there is
import from workingtree.py:

from bzrlib.workingtree import WorkingTree, WorkingTree3, WorkingTreeFormat3

It won't work because initialization of workingtree.py is not finished yet.