[MERGE] Add simple script for checking that all bugs in NEWS are closed in launchpad.

Aaron Bentley aaron at aaronbentley.com
Mon Feb 2 13:34:29 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> On Sun, 2009-02-01 at 23:20 -0500, Aaron Bentley wrote:
>> Jelmer Vernooij wrote:
>>> This patch adds a simple script in tools/ that can check that all bugs
>>> that are mentioned in NEWS are actually marked as "Fix Released" in
>>> launchpad. It uses the launchpadbugs python module packaged in Ubuntu.
>> bb:comment
>>
>> I think this is a great idea, but I'm not sure it belongs in bzr.
>>
>> This is mostly useful to bzr developers.  Other projects don't
>> necessarily use the same NEWS format as bzr does.  For other projects,
>> "Fix released" isn't handled the same way as in bzr.
> This is why I put it into tools/; since it's useful for people working
>  on Bazaar, but not really as something that should be installed by
>  Bazaar. I think some of the other files in tools/ fall into the same category.

Okay, that's reasonable.

>> It also adds a dependency on launchpadbugs.  There's a tightrope we walk
>> between making bzr completely bugtracker-neutral and making it
>> completely dependent on Launchpad.  Also, why launchpadbugs instead of
>> using launchpadlib?
> launchpadlib and launchpadbugs are both not packaged in Debian, but
> launchpadlib also has two dependencies (wadlib, httplib2 >= 0.4.0) that
> are not packaged in Debian.

- From a quick glance over the project (which doesn't really describe
itself), I got the impression that launchpadbugs was itself based on
launchpadlib.  That turns out to be wrong.

I do think that useful tools can be built that integrate launchpadlib
with bzrlib.  E.g. code review/merge directive stuff, marking branches
merged.  But that's not a reason to merge this.  I do hope Debian
supports launchpadlib soon, though.

> I don't think putting it
> into the "useful devtools" directory would imply making it mandatory to
> use, or would mean tighter dependencies to Launchpad.

I think it adds a "suggests launchpadbugs" to the dependency listing, no?

Anyhow, I have no objection to this being merged.  But I haven't read it
closely enough to review it.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmG9mIACgkQ0F+nu1YWqI37owCdFu7cVRwSTkeifhxNq+UXTa2+
QSIAn1oWCdHK2T9sdFfiaVCBB1g0B76I
=mYR7
-----END PGP SIGNATURE-----



More information about the bazaar mailing list