[MERGE][#321066] "bzr log -r 1.1.1..1" dotted revnos in the wrong order raises ValueError

[Marius Kruger]

2009/1/27 John Arbash Meinel <john at arbash-meinel.com>

> +            self.assertTrue('revno: %s\n' % revno not in log,
> +                'Contains unexpected revno %s' % revno)
>
> ^- I would find this easier to read as:
> self.assertFalse(('revno: %s\n' % revno) in log)
>
> The extra parenthesis make it clear that it isn't
> 'revno: %s\n' % (revno not in log)
>
> Also, I think "assertFalse((x in y))" is a tiny bit clearer than
> "assertTrue((x not in y))" but that is certainly a personal taste thing,
> and you can do it however you like.
>

it makes sense. done.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20090127/214d0c5c/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20090127_0105-log_reversed_dotted_revnos.patch
Type: text/x-patch
Size: 8447 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20090127/214d0c5c/attachment.bin