[MERGE] Branch.iter_merge_sorted_revisions

[Martin Pool]

Martin Pool has voted tweak.
Status is now: Conditionally approved
Comment:
This looks very tidy to me.

+        """Walk the revisions for a branch in merge sorted order.

Maybe add/copy a one-sentence definition of 'merge sorted'?

+
+        :return: an iterator over
+            (revision_id, depth, revno, end_of_merge) tuples.

I'd like to see some description of what end_of_merge is.

+            if stop_revision_id is not None and rev_id == 
stop_revision_id:
+                raise StopIteration

Is this different to just exiting the generator function?  If so, maybe
explain why?

If you've addressed all John's comments then I think it's good to go.

--
Martin


For details, see: 
http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C497A3749.5050104%40internode.on.net%3E
Project: Bazaar