mbp at canonical.com
Fri Jan 23 23:49:15 GMT 2009
Martin Pool has voted tweak.
Status is now: Conditionally approved
This looks very tidy to me.
+ """Walk the revisions for a branch in merge sorted order.
Maybe add/copy a one-sentence definition of 'merge sorted'?
+ :return: an iterator over
+ (revision_id, depth, revno, end_of_merge) tuples.
I'd like to see some description of what end_of_merge is.
+ if stop_revision_id is not None and rev_id ==
+ raise StopIteration
Is this different to just exiting the generator function? If so, maybe
If you've addressed all John's comments then I think it's good to go.
For details, see:
More information about the bazaar