[MERGE][BUG 315737] Fix failing test when CompiledChunksToLines is not available.

Aaron Bentley aaron at aaronbentley.com
Sat Jan 10 22:27:49 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:
>> The test seems odd-- If it's checking that chunks_to_lines is compiled,
>> why doesn't it just requireFeature(CompiledChunksToLinesFeature)?

> It is testing that if the compiled extension is available that it is
> used. It isn't meant to be testing that you have the feature available,
> that is done elsewhere.

Requiring a feature causes the test to be skipped if the feature is not
present.  It wouldn't cause the test to fail if the feature was unavailable.

I didn't express myself well.  I understand the bit about checking that
if it's compiled, it's used.  What I don't understand is the else
branch, which checks that if the compiled version isn't present, the
python version is used.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAklpIOIACgkQ0F+nu1YWqI1/pQCfVSTXQkqVhicHemEW8Gu1q0U9
1cQAn0tFiywibfM0xlKzJRglvf8LHuEU
=PhCY
-----END PGP SIGNATURE-----



More information about the bazaar mailing list