[MERGE][BUG 315737] Fix failing test when CompiledChunksToLines is not available.

John Arbash Meinel john at arbash-meinel.com
Sat Jan 10 20:40:28 GMT 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Vincent Ladeuil wrote:
>> Funny... I had the fix sitting on my desk, first as part of an
>> abandoned submission, then as part as an ongoing
>> python-2.6-and-osX-non-regression check and the bug finally got
>> reported...
> 
>> The bug is that the test forgot to call the available() method of
>> the test feature making it succeed unconditionally.
> 
> Thanks, that's bitten me a few times.
> 
> bb:approve.
> 
> The test seems odd-- If it's checking that chunks_to_lines is compiled,
> why doesn't it just requireFeature(CompiledChunksToLinesFeature)?
> 
> Aaron

It is testing that if the compiled extension is available that it is
used. It isn't meant to be testing that you have the feature available,
that is done elsewhere.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAklpB7wACgkQJdeBCYSNAAO61wCfbHClhR+dyRsHhSehvsBitoU+
24kAnRLbxl7zVey9tv7HviA3YQYyeEMH
=lp/j
-----END PGP SIGNATURE-----



More information about the bazaar mailing list