[MERGE] Add ls-shelf command

[Colin D Bennett]

On Tue, 02 Dec 2008 01:14:34 -0500
Aaron Bentley <aaron at aaronbentley.com> wrote:

> Robert Collins wrote:
> > On Tue, 2008-12-02 at 00:57 -0500, Aaron Bentley wrote:
> >> Hi all,
> >>
> >> This patch adds an ls-shelf command that will list the shelved
> >> changes. If a message was provided for the shelf, it is shown.
> > 
> > I haven't read the code yet; but what do you think of doing
> > 'bzr shelf list' instead, as the older shelf did?
> 
> I thought that the similarity of "shelf" and "shelve" was unfortunate,
> and I'm not a great fan of sub-sub commands.
> 
> Some of the functionality of "shelf" is unneeded: "switch", "upgrade".
> I've put other functionality on "unshelve":
> shelf show => unshelve --dry-run
> shelf delete => unshelve --delete

As a user, I find this very unintuitive.  I guess from one standpoint
you can consider 'showing' the contents of a shelf as a type of
unshelving when you use the metaphor of a physical book on a physical
shelf (since you have to temporarily take the book off the shelf to
look at it), but I really find "unshelve --dry-run" as a non-intuitive
way of showing the contents of a shelved set of changes.  I think that
when I want to just look at the contents of a shelf, it's fundamentally
different from my standpoint as a user than the case of unshelving the
changes and applying the patch to my working tree.

Just my humble opinion.

Regards,
Colin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081203/1a0460f8/attachment.pgp