[MERGE][#299313] --local commits are accessing the network

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Mon, 2008-11-24 at 23:18 -0500, Jelmer Vernooij wrote:
>> This should wait for 1.10 since it breaks the API. _get_nick() should 
>> probably become public (in other words, be renamed to get_nick).
> 
> Its a regression as it stands. I don't think _get_nick -> get_nick makes
> sense: implementors of branches have to offer methods that library
> clients don't use; making it public is a silly way to signal 'may have
> to override'.
> 
> -Rob

Originally I felt that changing to ".get_nick()" wasn't necessary, but
looking at the code. It is now the "official" way to get the branch
nickname, instead of "branch.nick" (because you can't pass
possible_transports and local=True to a property).

So I *do* think that it should be upgraded to a public function. Though
I guess I would try to do it compatibly by adding a new
"Branch.get_nick()" function that can fall back to "self._get_nick()" if
the branch implementation hasn't provided the right customized form.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkk0QVQACgkQJdeBCYSNAANDuQCfYOFYW5W1fF3ZHYV43rnDi3ht
YCIAn3DlFoUauklWDJUcSqi5aIb8CV08
=V5D5
-----END PGP SIGNATURE-----