[MERGE] Add test for smart client invoking server-side hook on set_last_revision_info

John Arbash Meinel john at arbash-meinel.com
Tue Nov 25 17:47:52 GMT 2008


John Arbash Meinel has voted tweak.
Status is now: Conditionally approved
Comment:
Andrew, any chance you could follow up on this?

...

BB:tweak

I think it is genuinely necessary to do this, but I also think it needs 
to be
done at a higher level.

Namely, at WT.commit() and WT/Branch.push
That is what happened with set_rh(). We just stopped calling
'set_revision_history' when we switched to set_last_revision_info.

And theoretically, we only *need* to call 'set_last_revision()', so a 
future
branch format might only use that.

*I* am the one that broke set_rh, but that is partially because I didn't
realize I was breaking it, and partially because it needed to be 
switched. But
if we had a 'bzr commit fires set_last_revision hook', we would have at 
least
been aware and the opportunity to make a decision.

John
=:->

For details, see: 
http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C20080714010508.GG9654%40steerpike.home.puzzling.org%3E
Project: Bazaar



More information about the bazaar mailing list