[Success!] [MERGE] Fix #296620 by allowing plugins instead of requiring them.

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
>>>>>> "aaron" == Aaron Bentley <aaron at aaronbentley.com> writes:
> 
>     aaron> In the future, I'd appreciate it if you did not land patches while we
>     aaron> were still deciding whether they should go in.
> 
> That one got approved and I see no other votes, sorry for the
> misunderstanding if I was wrong. I thought the discussion were more on
> the general principle more than on the bug at hand.

It got submitted and approved while I was asleep.  As soon as I was
awake I got into the discussion.

It seems  that Martin misunderstood the issue because of your wording.
He said:

  I'm surprised bzr passes on pqm without this, since bzrtools should
  not be present

So he must have thought that you were talking about a hard dependency,
and that is not the case here.  This taints his approval of your patch.

It's true I didn't veto it.  I didn't want to until I was certain.

> So to summarize my position there:
> - there was a bug that made the test suite failing.

Not in what I saw.  All I saw was that too many tests were being run.
Perhaps you mean that the suite was failing because the bzrtools shelf
tests were broken, but I fixed them this morning.

> - I fixed that.

If you're referring to the shelf failures, I fixed them in bzrtools
before you landed this patch, so on that basis you did not need to land
this patch.

> You may argue that this root problem is not addressed by my patch but I
> see no reason to block it during the discussion

I have two problems with your patch
1. It provides a fragile solution
2. It provides a mechanism for colorizing diffs that I think is
   insufficient.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkaRpQACgkQ0F+nu1YWqI3fXgCff/JK9qTeOzCMri784PJLeh8a
bKgAn2HlXQ8WTsgJwAi7KC+MhEfUfmMB
=M/JA
-----END PGP SIGNATURE-----