[Success!] [MERGE] Fix #296620 by allowing plugins instead of requiring them.
Vincent Ladeuil
v.ladeuil+lp at free.fr
Wed Nov 12 02:33:20 GMT 2008
>>>>> "aaron" == Aaron Bentley <aaron at aaronbentley.com> writes:
aaron> In the future, I'd appreciate it if you did not land patches while we
aaron> were still deciding whether they should go in.
That one got approved and I see no other votes, sorry for the
misunderstanding if I was wrong. I thought the discussion were more on
the general principle more than on the bug at hand.
So to summarize my position there:
- there was a bug that made the test suite failing.
- I fixed that.
Now we can discuss if we want to allow bzrlib to import plugins or not,
but I consider that another problem that need to be clearly specified and
tested.
You may argue that this root problem is not addressed by my patch but I
see no reason to block it during the discussion, but then that wasn't
what the bug was about when I reported it.
Vincent
More information about the bazaar
mailing list