[MERGE][bug #277484] win32/python2.4 extension fixes
John Arbash Meinel
john at arbash-meinel.com
Tue Oct 21 16:55:00 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
The walkdirs_win32.pyx file doesn't compile properly with python2.4. It
seems this line fails:
cdef readonly __int64 st_size
Apparently python2.4 doesn't define T_LONGLONG as something it can
automatically wrap as part of a structure. So instead I went with the
property route that Robert used for the _readdir code.
Second, it seems that MSVC doesn't define any of the nice S_ISREG macros
for a simple check of the mode flags. It seems that mingw32 defines
everything we need except for S_ISLNK, but I just extended it a bit
further to define anything else that seems to be missing.
I was able to test that with this patch I can build using mingw32 and
python2.4, I wasn't able to test using msvc because I don't have it
here. The fix is pretty straightforward, but it would be nice if someone
else could test it.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
More information about the bazaar