[MERGE] PreviewTree.iter_changes supports all parameters

Aaron Bentley aaron at aaronbentley.com
Thu Oct 16 21:13:18 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Aaron Bentley wrote:

>> When we were only using PreviewTree.iter_changes for doing diffs, it was
>> okay for it to not support the set of parameters.  But now, with Shelf
>> 2, we want more from it, and we can use the default iter_changes
>> implementation to get that.

> Seems like a cheap implementation (you just thunk back to the generic),
> but as long as we are on the "make it work, make it right" phase (and
> may not need the "make it fast" for a while).

Yep.  Performance is reasonable when unshelving bzr.dev itself, at least.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkj3oF0ACgkQ0F+nu1YWqI0FOgCeL+93jvkoPBKNMhrpZH4/96BX
/iQAoIkej1mHVCSgho1yGmgxdPeH8aea
=0R7R
-----END PGP SIGNATURE-----



More information about the bazaar mailing list