[MERGE] PreviewTree.iter_changes supports all parameters

Thu Oct 16 20:40:45 BST 2008

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Hi all,
> 
> When we were only using PreviewTree.iter_changes for doing diffs, it was
> okay for it to not support the set of parameters.  But now, with Shelf
> 2, we want more from it, and we can use the default iter_changes
> implementation to get that.
> 
> Aaron

Seems like a cheap implementation (you just thunk back to the generic),
but as long as we are on the "make it work, make it right" phase (and
may not need the "make it fast" for a while).

BB:approve

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkj3mL0ACgkQJdeBCYSNAAMjqgCgr4Xp46GOwaT/wq/Heu44bUOx
XzsAn32dqwQ5LAxXsaiqvXIqD6TuLAS7
=Cj6N
-----END PGP SIGNATURE-----