[MERGE] dont stacktrace on bad plugin versions

[Marius Kruger]

2008/10/16 Forest Bond <forest at alittletooquiet.net>

> ...



> > +        try:
> > +            version_string = _format_version_tuple(version_info)
> > +        except:
> > +            # try to return something usefull for bad plugins, in stead
> of
> > +            # stack tracing.
> > +            version_string = '.'.join(map(str, version_info))
>
> This will mask other exceptions, including KeyboardInterrupt.  Should you
> specify which exceptions you may be expecting?


Good point, I suppose I can ignore that one.
I found code in server.py like:

       try:
            ...
        except KeyboardInterrupt:
            raise
        except Exception, e:
            trace.log_exception_quietly()

will that be ok?
is there any others we should ignore?

regards
marius
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20081016/7c9e7ab0/attachment.htm