[MERGE] dont stacktrace on bad plugin versions

[Forest Bond]

Hi,

On Thu, Oct 16, 2008 at 02:06:56AM +0200, Marius Kruger wrote:
> 2008/10/16 Forest Bond <forest at alittletooquiet.net>
> 
>     ...
> 
>  
> 
>     > +        try:
>     > +            version_string = _format_version_tuple(version_info)
>     > +        except:
>     > +            # try to return something usefull for bad plugins, in stead
>     of
>     > +            # stack tracing.
>     > +            version_string = '.'.join(map(str, version_info))
> 
>     This will mask other exceptions, including KeyboardInterrupt.  Should you
>     specify which exceptions you may be expecting?
> 
> 
> Good point, I suppose I can ignore that one.
> I found code in server.py like:
> 
>        try:
>             ...
>         except KeyboardInterrupt:
>             raise
>         except Exception, e:
>             trace.log_exception_quietly()
> 
> will that be ok?
> is there any others we should ignore?

KeyboardInterrupt is the one I'm most concerned about.  Otherwise, perhaps the
bzr devs have some conventions for dealing with this kind of situation.

-Forest
-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081015/865b61cd/attachment.pgp