RFC: install_revisions -> install_deltas ?

[Martin Pool]

On Wed, Oct 15, 2008 at 3:44 PM, Robert Collins
<robertc at robertcollins.net> wrote:
> On Wed, 2008-10-15 at 13:43 +1100, Martin Pool wrote:
>
>> This sounds reasonable to me.  I think this can be done without
>> reworking commit at the time, but I would be at least tempted to look
>> whether everything within commit could in principle be rewritten onto
>> this interface.
>
> Commit needs to infer file graph convergence; this interface is for
> systems that already know whether such convergence has happened at this
> point.

OK, then it might be worth documenting that they have to have set this
in the inventory entry revision_ids.  I guess the text is then taken
from the tree object?

(Will things like bzr-git really have already computed the file
graphs, I wonder?)

>> >    Each delta is fetched incrementally; if the basis revision is not
>> >    present then the tree object is used directly to obtain the content
>> >    of the new revision being inserted.
>> >
>>
>> However, if the basis revision is present in the destination object
>> then the delta must be supplied?  Is it OK to eg pass None as the
>> basis_revision_id and no delta?
>
> Not IMO :>.

Ok, but say so.  So the basis revision must always be the same as the
primary parent?  If so, is there any need to separately specify it?

-- 
Martin <http://launchpad.net/~mbp/>