[MERGE] Deprecate tree.find_renames

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Hi all,
> 
> Ever heard of the "renames" command?  Or tree.find_renames?  They were
> introduced in the prehistoric days of revision 164, and haven't changed
> much since then.  I just ran across find_renames today.
> 
> find_renames is a poor API nowadays, because it takes two inventories as
> its input.  But more unfortunately, it considers a file renamed if its
> parent directory is renamed.  So "bzr status" is a much better indicator
> of which files have actually been renamed.
> 
> I've started by deprecating find_renames, because inventory-based APIs
> are bad.  I've implemented cmd_renames in terms of iter_changes.
> 
> I'm also inclined to hide the "renames" command.  Any objections?
> 
> Aaron

I would be fine hiding it if we had another way to get the information.
But we only have "ls" which is a snapshot (doesn't consider deltas). We
have 'status' but no way to restrict its output.

So I'm happy with this patch, and would like to see us do something
different than "bzr renames", but I don't think we can hide it just yet.

BB:approve

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjyFM4ACgkQJdeBCYSNAAOViACg1OC6Tk/zjxGZHlblI1Ob6Clz
yDIAn2DoI709HlVPS7jkJTRFBpjzbYca
=JCCQ
-----END PGP SIGNATURE-----