[MERGE] Deprecate tree.find_renames

Aaron Bentley aaron at aaronbentley.com
Sun Oct 12 15:44:11 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

For some reason, this was marked superseded, but I don't think that's
accurate.  Could someone look at it?

Aaron

Aaron Bentley wrote:
> Hi all,
> 
> Ever heard of the "renames" command?  Or tree.find_renames?  They were
> introduced in the prehistoric days of revision 164, and haven't changed
> much since then.  I just ran across find_renames today.
> 
> find_renames is a poor API nowadays, because it takes two inventories as
> its input.  But more unfortunately, it considers a file renamed if its
> parent directory is renamed.  So "bzr status" is a much better indicator
> of which files have actually been renamed.
> 
> I've started by deprecating find_renames, because inventory-based APIs
> are bad.  I've implemented cmd_renames in terms of iter_changes.
> 
> I'm also inclined to hide the "renames" command.  Any objections?
> 
> Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjyDTYACgkQ0F+nu1YWqI0zCgCdGQ8j43r1tVaMh4+l5aQ6bjzO
f7gAnRclmpyvih/t2fq2whFwdqaaia4b
=FQxw
-----END PGP SIGNATURE-----



More information about the bazaar mailing list