[MERGE/RFC] Use True/False objects for iter_changes

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Tue, 2008-10-07 at 16:25 -0500, John Arbash Meinel wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> It seems that bzr-gtk copied the same if/else block that Robert fixed
>> when he changed the pyrex iter_changes to return 1/0 instead of True/False.
>>
>> Which means that bzr-gtk breaks if you use the compiled extensions. We
>> can certainly update bzr-gtk, but we can also play nicely with existing
>> versions.
>>
>> For pyrex 0.9.8.5 this should be reasonably fast, as it accesses the
>> Py_True object directly (rather than looking it up by name). I don't
>> know if that is true for older versions.
>>
>> Thoughts?
> 
> I think the if/else block was a silly concept we had in the past, I
> suggest bzr-gtk change. (Particularly as 1.7 is out there and released
> already).
> 
> -Rob

1.7 doesn't have your iter_changes included. So it isn't exactly
relevant. 1.8rc1 does, but it is just an RC.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjr2msACgkQJdeBCYSNAAOsbwCeIYsPtyG42n9CwlxicOeXLmBx
FBMAnRzXheFEVoMCwnnzFv/HkXe17Nj9
=OFbm
-----END PGP SIGNATURE-----