[MERGE/RFC] Use True/False objects for iter_changes

[Robert Collins]

On Tue, 2008-10-07 at 16:25 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> It seems that bzr-gtk copied the same if/else block that Robert fixed
> when he changed the pyrex iter_changes to return 1/0 instead of True/False.
> 
> Which means that bzr-gtk breaks if you use the compiled extensions. We
> can certainly update bzr-gtk, but we can also play nicely with existing
> versions.
> 
> For pyrex 0.9.8.5 this should be reasonably fast, as it accesses the
> Py_True object directly (rather than looking it up by name). I don't
> know if that is true for older versions.
> 
> Thoughts?

I think the if/else block was a silly concept we had in the past, I
suggest bzr-gtk change. (Particularly as 1.7 is out there and released
already).

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20081008/3790adae/attachment.pgp