Personal experiences/anecdotes of the bzr review processes

[Mark Hammond]

> I don't think that's accurate.  See:
> http://bundlebuggy.aaronbentley.com/project/bzr/request/<011301c90e83%2
> 43d0d0d60%24b7272820%24%40com.au>
> http://thread.gmane.org/gmane.comp.version-control.bazaar-
> ng.general/45924/focus=46623

I'm sorry, but that link is currently offering:

"""
  File "/var/lib/python-support/python2.5/turbogears/controllers.py", line
405, in _execute_func
    output = errorhandling.try_call(func, *args, **kw)
  File "/var/lib/python-support/python2.5/turbogears/errorhandling.py", line
72, in try_call
    return func(self, *args, **kw)
  File "/opt/BundleBuggy/bundlebuggy/controllers.py", line 194, in view
    project_id = request.project_id
AttributeError: ("'NoneType' object has no attribute 'project_id'", <bound
method Root.default of <bundlebuggy.controllers.Root object at 0x8fade8c>>)

"""

> John definitely approved the Sept 4 patch that Ian voted resubmit on.

Hrm -
http://thread.gmane.org/gmane.comp.version-control.bazaar-ng.general/45924/f
ocus=46623 doesn't show any such approval.  Are we expected to manually
check the status of bundlebuggy for manual approvals for each patch we
submit via the mailing list?  If so it might be worth mentioning that
requirement somewhere.

But even then, I'm surprised BB didn't pick up the second approval from Ian
and merge it automatically.  I must be missing some part of the process?

> Also, I don't think it would have been out of line for you to ask Ian
> to submit it.

I'm a little confused then as to why you didn't pick up that same state
then?  I'm not intimate with the process, and given BB didn't inform me that
John had already approved (and it seems you weren't aware when you made your
review, or you wouldn't have bothered), I hope it *is* clear why I didn't
ask for a formal merge before I was aware of the 2 approvals.

> Well, I didn't vote either way because I wanted your comments.  You
> could say you think the issues I pointed out aren't worth fixing, and I
> might well vote Approve.

I hope I did.  Does that mean you will?  It would be appreciated.

> I'm sorry that's been your experience.  We definitely want to improve
> the process.  Do you have any suggestions?

Voting "approve" and getting this patch landed would be an excellent start.
I'd also suggest that a formal "style guide" (aka pep8 with bzr specific
requirements) be adopted, and if a patch is technically correct (ie, fixes
the bug/correctly implements the feature) and doesn't violate a *specific*
requirement in that style-guide, then all style related
issues/suggestions/color-selections be dealt with independently of the
technical issue being addressed.

Cheers,

Mark