Personal experiences/anecdotes of the bzr review processes

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mark Hammond wrote:
> * 4 Sept, John asks for another tweak in a comment block
> * 4 Sept, I resubmit
> [Note: no 'approve' from John ever comes]

I don't think that's accurate.  See:
http://bundlebuggy.aaronbentley.com/project/bzr/request/<011301c90e83%243d0d0d60%24b7272820%24%40com.au>
http://thread.gmane.org/gmane.comp.version-control.bazaar-ng.general/45924/focus=46623

John definitely approved the Sept 4 patch that Ian voted resubmit on.
It's true that he didn't vote on your 19 Sept one.

> * 19 Sept, Ian reviews and notes tests fail on non-windows platform.
> * 19 Sept, I resubmit
> * 19 Sept, Ian votes approve

At this point, I think Ian should have submitted it to PQM.  I'm not
sure whether he remembered that the Sept 4 patch had already been
approved by John.

I can think of two ways to handle this in the future:
1. Once someone has approved something, expect them to continue
approving future versions until the patch is ready to land.

2. Teach Bundle Buggy to propagate old approvals into new patches.  Of
course, this is tricker when we'd have to turn a 'tweak' into an
'approve', but it could be done.

Also, I don't think it would have been out of line for you to ask Ian to
submit it.

> [first approval!]
> * 23 Sept, Aaron re-reviews, picks up on various stylistic issues, it seems
> we are back at square one. 

Well, I didn't vote either way because I wanted your comments.  You
could say you think the issues I pointed out aren't worth fixing, and I
might well vote Approve.

> While I understand the importance of keeping
> a close eye on quality, the reality is from my personal POV, the cost of
> submitting improvements that aren't *critical* for my work are very close to
> being too high to bother with...

I'm sorry that's been your experience.  We definitely want to improve
the process.  Do you have any suggestions?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFI2N/30F+nu1YWqI0RAsBYAJ90MKEhk8DPIS8YCMQ8rxaM/dLIcgCdGkp8
xHS5lNwMcQEbvpeW/UNmJz8=
=Omp5
-----END PGP SIGNATURE-----