[MERGE] Relocate iter_changes' process_entry method to allow C optimisation.

Robert Collins robertc at robertcollins.net
Wed Sep 17 03:35:31 BST 2008


On Tue, 2008-09-16 at 20:42 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> > This is a simple relocation of an inner method into a class-with-state
> > that can be later C optimised.
> > 
> > No specific tests for it, but its a private method and fully tested via
> > the iter_changes logic.
> > 
> > -Rob
> > 
> 
> I didn't look closely, as I assume this is primarily just a
> cut-and-paste change. If it isn't, let me know and I'll look closer.

It was, but it was actually quite broken - missing references :).

I've a much larger relocation in the works, which changes iter_changes'
core into a class and then supplies that from both pyrex and
dirstate.py; the cut-n-paste aspect of it should still be quite evident
- no structural changes anticipated.

I hope to reach a total 50% improvement in bzr status time with that;
will keep people posted.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080917/dd70e9ff/attachment.pgp 


More information about the bazaar mailing list